Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge | Diagnostic Files #3213

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

benrr101
Copy link
Contributor

Description: More work as part of the merge project. This one is pretty straightforward - the SqlDiagnostic* classes only belonged to the netcore project, so this PR:

  • Moves the files over to the common project in a Diagnostics folder
  • Split the files into one class per file
  • Moved classes that weren't in the SqlClient.Diagnostics namespace into that namespace
  • Moved the extension methods for DiagnosticsListener class into the DiagnosticListener class
    • I can revert this if there's significant backlash to the change, but considering the code is all internal, to me, there's no real reason to keep these as extension methods.
  • Also created stubs for SqlCommand and SqlConnection in common project to make it a bit easier to work on the Diagnostic files.

Testing: No functional changes to the code, CI should be able to validate.

@benrr101 benrr101 added the Common Project 🚮 Things that relate to the common project project label Mar 12, 2025
@benrr101 benrr101 requested a review from a team March 12, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Common Project 🚮 Things that relate to the common project project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant